[
https://issues.apache.org/jira/browse/FLINK-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065960#comment-16065960
]
ASF GitHub Bot commented on FLINK-7014:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124457316
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -422,4 +423,50 @@ class ExpressionReductionTest extends TableTestBase {
util.verifyTable(result, expected)
}
+ @Test(expected = classOf[NullPointerException])
+ def testReduceDeterministicUDF(): Unit = {
--- End diff --
The exception isn't caused by Flink, to check an unexpected exception is
not a good way. I suggest to mark this test as `@Ignore` and add a TODO comment
on the top of the test. After CALCITE-1860 is fixed, we can reopen this test or
check&remove this test.
> Expose isDeterministic interface to ScalarFunction and TableFunction
> --------------------------------------------------------------------
>
> Key: FLINK-7014
> URL: https://issues.apache.org/jira/browse/FLINK-7014
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Ruidong Li
> Assignee: Ruidong Li
>
> Currently, the `isDeterministic` method of implementations of `SqlFuntion`
> are always returning true, which cause inappropriate optimization in Calcite,
> such as taking user's stateful UDF as a pure functional procedure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
