Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4195#discussion_r124500395
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
 ---
    @@ -270,10 +270,12 @@ private void updateLastSeenWatermark(long timestamp) {
        }
     
        private void updateNFA(NFA<IN> nfa) throws IOException {
    -           if (nfa.isEmpty()) {
    -                   nfaOperatorState.clear();
    -           } else {
    -                   nfaOperatorState.update(nfa);
    +           if (nfa.isNFAChanged()) {
    +                   if (nfa.isEmpty()) {
    +                           nfaOperatorState.clear();
    +                   } else {
    +                           nfaOperatorState.update(nfa);
    --- End diff --
    
    This is only true for the `RocksDB` state backend. If you are using the 
`Heap` state backend, you do not (de)serialize at every access but you keep the 
same object. So the flag should be re-set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to