[
https://issues.apache.org/jira/browse/FLINK-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066544#comment-16066544
]
ASF GitHub Bot commented on FLINK-6358:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r124547670
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -305,6 +334,41 @@ public static void main(String[] args) throws
Exception {
default:
throw new
ProgramParametrizationException("Unknown output type: " + outputName);
}
+
+ //
----------------------------------------------------------------------------------------
+ // Write job details
--- End diff --
It would nicer to extract this if condition to `writeJobDetails` method and
delete this comment
> Write job details for Gelly examples
> ------------------------------------
>
> Key: FLINK-6358
> URL: https://issues.apache.org/jira/browse/FLINK-6358
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Affects Versions: 1.3.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Minor
>
> Add an option to write job details to a file in JSON format. Job details
> include: job ID, runtime, parameters with values, and accumulators with
> values.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
