[
https://issues.apache.org/jira/browse/FLINK-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069780#comment-16069780
]
ASF GitHub Bot commented on FLINK-7044:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4225#discussion_r124999617
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java
---
@@ -534,33 +537,66 @@ public Integer getKey(Tuple2<Integer, Long> value)
throws Exception {
* Retry a query for state for keys between 0 and {@link #NUM_SLOTS}
until
* <tt>expected</tt> equals the value of the result tuple's second
field.
*/
- private void executeValueQuery(final Deadline deadline,
- final QueryableStateClient client, final JobID jobId,
- final QueryableStateStream<Integer, Tuple2<Integer, Long>>
queryableState,
- final long expected) throws Exception {
+ private void executeValueQuery(
--- End diff --
There's nothing in the method signature that restricts this to
`ValueState`. I think this can just be `executeQuery()`.
> Add methods to the client API that take the stateDescriptor.
> ------------------------------------------------------------
>
> Key: FLINK-7044
> URL: https://issues.apache.org/jira/browse/FLINK-7044
> Project: Flink
> Issue Type: Improvement
> Components: Queryable State
> Affects Versions: 1.3.0, 1.3.1
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
