Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4225#discussion_r125007394
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java
 ---
    @@ -534,33 +537,66 @@ public Integer getKey(Tuple2<Integer, Long> value) 
throws Exception {
         * Retry a query for state for keys between 0 and {@link #NUM_SLOTS} 
until
         * <tt>expected</tt> equals the value of the result tuple's second 
field.
         */
    -   private void executeValueQuery(final Deadline deadline,
    -           final QueryableStateClient client, final JobID jobId,
    -           final QueryableStateStream<Integer, Tuple2<Integer, Long>> 
queryableState,
    -           final long expected) throws Exception {
    +   private void executeValueQuery(
    --- End diff --
    
    Yes you are right! Value here is used in the sense of "asking the value for 
a key" not in the sense of `ValueState` which is a scalar. I will change this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to