[
https://issues.apache.org/jira/browse/FLINK-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070228#comment-16070228
]
ASF GitHub Bot commented on FLINK-7053:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4234
[FLINK-7053] improve code quality in some tests
* `BlobClientTest` and `BlobClientSslTest` share a lot of common code
* the received buffers there are currently not verified for being equal to
the expected one
* `TemporaryFolder` should be used throughout blob store tests
This PR is based upon #4158 in a series of PRs to implement FLINK-6916.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-6916-7053
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4234
----
commit d54a316cfffd8243980df561fd4fcbd99934a40b
Author: Nico Kruber <[email protected]>
Date: 2016-12-20T15:49:57Z
[FLINK-6008][docs] minor improvements in the BlobService docs
commit b215515fa14d3f6af218e86b67bc2c27ae9d4f4f
Author: Nico Kruber <[email protected]>
Date: 2016-12-20T17:27:13Z
[FLINK-6008] refactor BlobCache#getURL() for cleaner code
commit bbcde52b3105fcf379c852b568f3893cc6052ce6
Author: Nico Kruber <[email protected]>
Date: 2016-12-21T15:23:29Z
[FLINK-6008] do not fail the BlobServer if delete fails
also extend the delete tests and remove one code duplication
commit dda1a12e40027724efb0e50005e5b57058a220f0
Author: Nico Kruber <[email protected]>
Date: 2017-01-06T17:42:58Z
[FLINK-6008][docs] update some config options to the new, non-deprecated
ones
commit e12c2348b237207a50649d515a0fbbd19f92e6a0
Author: Nico Kruber <[email protected]>
Date: 2017-03-09T17:14:02Z
[FLINK-6008] use Preconditions.checkArgument in BlobClient
commit 24060e01332c6df9fd01f1dc5f321c3fda9301c1
Author: Nico Kruber <[email protected]>
Date: 2017-03-17T15:21:40Z
[FLINK-6008] fix concurrent job directory creation
also add according unit tests
commit 2e0d16ab8bf8a48a2d028602a3a7693fc4b76039
Author: Nico Kruber <[email protected]>
Date: 2017-06-14T16:01:47Z
[FLINK-6008] do not guard a delete() call with a check for existence
commit 7ba911d7ecb4861261dff8509996be0bd64d6d27
Author: Nico Kruber <[email protected]>
Date: 2017-04-18T14:37:37Z
[FLINK-6008] some comments about BlobLibraryCacheManager cleanup
commit d3f50d595f85356ae6ed0a85e1f8b8e8ac630bde
Author: Nico Kruber <[email protected]>
Date: 2017-04-19T13:39:03Z
[hotfix] minor typos
commit 79b6ce35a9e246b35415a388295f9ee2fc19a82e
Author: Nico Kruber <[email protected]>
Date: 2017-04-19T14:10:16Z
[FLINK-6008] further cleanup tests for BlobLibraryCacheManager
commit 23fb6ecd6c43c86d762503339c67953290236dca
Author: Nico Kruber <[email protected]>
Date: 2017-06-30T14:03:16Z
[FLINK-6008] address PR comments
commit 794764ceeed6b9bbbac08662f5754b218ff86c9c
Author: Nico Kruber <[email protected]>
Date: 2017-06-16T08:51:04Z
[FLINK-7052][blob] remove (unused) NAME_ADDRESSABLE mode
commit 774bafa85f242110a2ce7907c1150f8c62d73b3f
Author: Nico Kruber <[email protected]>
Date: 2017-06-21T15:05:57Z
[FLINK-7052][blob] remove further unused code due to the NAME_ADDRESSABLE
removal
commit 4da3b3f6269e43bf1c66621099528824cad9373f
Author: Nico Kruber <[email protected]>
Date: 2017-06-22T15:31:17Z
[FLINK-7053][blob] remove code duplication in BlobClientSslTest
This lets BlobClientSslTest extend BlobClientTest as most of its
implementation
came from there and was simply copied.
commit aa9cdc820f9ca1a38a19708bf45a2099e42eaf48
Author: Nico Kruber <[email protected]>
Date: 2017-06-23T09:40:34Z
[FLINK-7053][blob] verify some of the buffers returned by GET
commit c9b693a46053b55b3939ff471184796f12d36a72
Author: Nico Kruber <[email protected]>
Date: 2017-06-23T10:04:10Z
[FLINK-7053][blob] use TemporaryFolder for local BLOB dir in unit tests
This replaces the use of some temporary directory where it is not guaranteed
that it will be deleted after the test.
----
> improve code quality in some tests
> ----------------------------------
>
> Key: FLINK-7053
> URL: https://issues.apache.org/jira/browse/FLINK-7053
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> * {{BlobClientTest}} and {{BlobClientSslTest}} share a lot of common code
> * the received buffers there are currently not verified for being equal to
> the expected one
> * {{TemporaryFolder}} should be used throughout blob store tests
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
