[
https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070419#comment-16070419
]
ASF GitHub Bot commented on FLINK-7058:
---------------------------------------
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/4240
[FLINK-7058] Fix scala-2.10 dependencies
First commit is from #4209 and should be ignored in this PR
Before fixup:
```
$ mvn dependency:tree -pl flink-scala | grep quasi
[INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
$ mvn dependency:tree -pl flink-scala -Pscala-2.11 | grep quasi
[INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
$ mvn dependency:tree -pl flink-scala -Pscala-2.10 | grep quasi
[INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
```
After fixup:
```
$ mvn dependency:tree -pl flink-scala | grep quasi
$ mvn dependency:tree -pl flink-scala -Pscala-2.11 | grep quasi
$ mvn dependency:tree -pl flink-scala -Pscala-2.10 | grep quasi
[INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink scala210
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4240
----
commit a17b0d4aee3c116761871513b2ef073bf8a98750
Author: Piotr Nowojski <[email protected]>
Date: 2017-06-23T11:41:55Z
[FLINK-7030] Build with scala-2.11 by default
commit 58a3b7b0a936da0148de4ddb5b9a6b2c3bccc335
Author: Piotr Nowojski <[email protected]>
Date: 2017-06-30T16:19:59Z
[FLINK-7058] Fix scala-2.10 dependencies
----
> flink-scala-shell unintended dependencies for scala 2.11
> --------------------------------------------------------
>
> Key: FLINK-7058
> URL: https://issues.apache.org/jira/browse/FLINK-7058
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.3.0, 1.3.1
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Minor
>
> Activation of profile scala-2.10 in `flink-scala-shell` and `flink-scala` do
> not work as intended.
> {code:xml}
> <profiles>
> <profile>
> <id>scala-2.10</id>
> <activation>
> <property>
> <name>!scala-2.11</name>
> </property>
> </activation>
> <dependencies>
> <dependency>
> <groupId>org.scalamacros</groupId>
>
> <artifactId>quasiquotes_2.10</artifactId>
>
> <version>${scala.macros.version}</version>
> </dependency>
> <dependency>
> <groupId>org.scala-lang</groupId>
> <artifactId>jline</artifactId>
> <version>2.10.4</version>
> </dependency>
> </dependencies>
> </profile>
> </profiles>
> <activation>
> </activation>
> {code}
> This activation IMO have nothing to do with `-Pscala-2.11` profile switch
> used in our build. "properties" are defined by `-Dproperty` switches. As far
> as I understand that, those additional dependencies would be added only if
> nobody defined property named `scala-2.11`, which means, they would be added
> only if switch `-Dscala-2.11` was not used, so it seems like those
> dependencies were basically added always. This quick test proves that I'm
> correct:
> {code:bash}
> $ mvn dependency:tree -pl flink-scala | grep quasi
> [INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
> $ mvn dependency:tree -pl flink-scala -Pscala-2.11 | grep quasi
> [INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
> $ mvn dependency:tree -pl flink-scala -Pscala-2.10 | grep quasi
> [INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
> {code}
> regardless of the selected profile those dependencies are always there.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
