Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3583#discussion_r125088693
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -1070,9 +1088,9 @@ public void suspend(Throwable suspensionCause) {
* exceptions that indicate a bug or an unexpected call race), and
where a full restart is the
* safe way to get consistency back.
*
- * @param t The exception that caused the failure.
+ * @param errorInfo ErrorInfo containing the exception that caused the
failure.
*/
- public void failGlobal(Throwable t) {
+ public void failGlobal(ErrorInfo errorInfo) {
--- End diff --
Why don't we do a null check for `errorInfo` similar to the one in
`suspend`? I think it should be fine to assume that this parameter is not null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
