[ 
https://issues.apache.org/jira/browse/FLINK-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072132#comment-16072132
 ] 

ASF GitHub Bot commented on FLINK-5476:
---------------------------------------

Github user DmytroShkvyra commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4001#discussion_r125238449
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/program/StandaloneClusterClient.java
 ---
    @@ -70,6 +76,8 @@ public GetClusterStatusResponse getClusterStatus() {
                        } else {
                                throw new RuntimeException("Received the wrong 
reply " + result + " from cluster.");
                        }
    +           } catch (FlinkRuntimeException | FlinkException e) {
    --- End diff --
    
    Hi! @tillrohrmann , We can get there even FlinkException,. I just tried use 
more common approach for processing exception while getting Cluster status and 
prevent unpredictable test failure.  Maybe it would better throw there only 
FlinkRuntimeException in all cases. It makes job fail without any timeout.  
What do you think?


> Fail fast if trying to submit a job to a non-existing Flink cluster
> -------------------------------------------------------------------
>
>                 Key: FLINK-5476
>                 URL: https://issues.apache.org/jira/browse/FLINK-5476
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Dmytro Shkvyra
>            Priority: Minor
>
> In case of entering the wrong job manager address when submitting a job via 
> {{flink run}}, the {{JobClientActor}} waits per default {{60 s}} until a 
> {{JobClientActorConnectionException}}, indicating that the {{JobManager}} is 
> no longer reachable, is thrown. In order to fail fast in case of wrong 
> connection information, we could change it such that it uses initially a much 
> lower timeout and only increases the timeout if it had at least once 
> successfully connected to a {{JobManager}} before.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to