[
https://issues.apache.org/jira/browse/FLINK-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073356#comment-16073356
]
ASF GitHub Bot commented on FLINK-6649:
---------------------------------------
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4157#discussion_r125423153
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -37,6 +37,13 @@ class BatchQueryConfig private[table] extends QueryConfig
class StreamQueryConfig private[table] extends QueryConfig {
/**
+ * The non-windowed groupby aggregate update the calculation result
according a configuration of
+ * time interval. By default non-windowed groupby aggregate will update
calculation result each
+ * row.
+ */
+ private var unboundedAggregateUpdateInterval: Time = Time.milliseconds(0)
--- End diff --
I think `updateRate` meant update result in a fixed frequency, so we should
register a process-time timer. i.e., System clock driven the trigger. And
`updateInterval` meant update result according coming data. so I we should
register a event-time timer. i.e, Data driven the trigger.
I think it again, I suggest using `updateInterval`, i.e., we emit result
according event-time of data.
What do you think?
> Improve Non-window group aggregate with configurable `earlyFire`.
> -----------------------------------------------------------------
>
> Key: FLINK-6649
> URL: https://issues.apache.org/jira/browse/FLINK-6649
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Currently, Non-windowed group aggregate is earlyFiring at count(1), that is
> every row will emit a aggregate result. But some times user want config count
> number (`early firing with count[N]`) , to reduce the downstream pressure.
> This JIRA. will enable the config of e`earlyFiring` for Non-windowed group
> aggregate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
