[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073730#comment-16073730
]
ASF GitHub Bot commented on FLINK-6232:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r125457556
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
@@ -210,77 +187,71 @@ object JoinUtil {
case _ => Seq()
}
case c: RexCall =>
- c.operands.map(analyzeSingleConditionTerm(_, leftFieldCount,
inputType)).reduce(_++_)
+ c.operands.map(extractTimeIndicatorAccesses(_, leftFieldCount,
inputType)).reduce(_++_)
case _ => Seq()
}
}
/**
- * Extract time offset and determain which table the offset belong to
+ * Extract time offset and determain it's the lower bound of left
stream or the upper bound
+ *
+ * @return window boundary, is left lower bound
*/
def extractTimeOffsetFromCondition(
timeTerm: RexNode,
isLeftExprBelongLeftTable: Boolean,
rexBuilder: RexBuilder,
- config: TableConfig) = {
+ config: TableConfig): (Long, Boolean) = {
val timeCall: RexCall = timeTerm.asInstanceOf[RexCall]
- val leftLiteral =
- reduceTimeExpression(
- timeCall.operands.get(0),
- rexBuilder,
- config)
- val rightLiteral =
- reduceTimeExpression(
- timeCall.operands.get(1),
- rexBuilder,
- config)
-
- val (tmpTimeOffset: Long, isLeftTableTimeOffset: Boolean) =
+ val isLeftLowerBound: Boolean =
timeTerm.getKind match {
- // e.g a.proctime > b.proctime - 5 sec, we need to store stream a.
- // the left expr(a) belong to left table, so the offset belong to
left table
+ // e.g a.proctime > b.proctime - 5 sec, then it's the lower bound
of a and the value is -5
+ // e.g b.proctime > a.proctime - 5 sec, then it's not the lower
bound of a but upper bound
case kind @ (SqlKind.GREATER_THAN | SqlKind.GREATER_THAN_OR_EQUAL)
=>
- (rightLiteral - leftLiteral, isLeftExprBelongLeftTable)
- // e.g a.proctime < b.proctime + 5 sec, we need to store stream b.
+ isLeftExprBelongLeftTable
+ // e.g a.proctime < b.proctime + 5 sec, the the upper bound of a
is 5
case kind @ (SqlKind.LESS_THAN | SqlKind.LESS_THAN_OR_EQUAL) =>
- (leftLiteral - rightLiteral, !isLeftExprBelongLeftTable)
- case _ => 0
+ !isLeftExprBelongLeftTable
+ case _ =>
+ throw new TableException("Unsupport time-condition.")
--- End diff --
Unsupport -> Unsupported
> Support proctime inner equi-join between two streams in the SQL API
> -------------------------------------------------------------------
>
> Key: FLINK-6232
> URL: https://issues.apache.org/jira/browse/FLINK-6232
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: hongyuhong
> Assignee: hongyuhong
>
> The goal of this issue is to add support for inner equi-join on proc time
> streams to the SQL interface.
> Queries similar to the following should be supported:
> {code}
> SELECT o.proctime, o.productId, o.orderId, s.proctime AS shipTime
> FROM Orders AS o
> JOIN Shipments AS s
> ON o.orderId = s.orderId
> AND o.proctime BETWEEN s.proctime AND s.proctime + INTERVAL '1' HOUR;
> {code}
> The following restrictions should initially apply:
> * The join hint only support inner join
> * The ON clause should include equi-join condition
> * The time-condition {{o.proctime BETWEEN s.proctime AND s.proctime +
> INTERVAL '1' HOUR}} only can use proctime that is a system attribute, the
> time condition only support bounded time range like {{o.proctime BETWEEN
> s.proctime - INTERVAL '1' HOUR AND s.proctime + INTERVAL '1' HOUR}}, not
> support unbounded like {{o.proctime > s.protime}}, and should include both
> two stream's proctime attribute, {{o.proctime between proctime() and
> proctime() + 1}} should also not be supported.
> This issue includes:
> * Design of the DataStream operator to deal with stream join
> * Translation from Calcite's RelNode representation (LogicalJoin).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
