[
https://issues.apache.org/jira/browse/FLINK-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074632#comment-16074632
]
ASF GitHub Bot commented on FLINK-7105:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4259
[FLINK-7105] Make ActorSystems non daemonic
In order to not having to explicitly wait on the termination of an
ActorSystem
in the main thread, we now create the ActorSystems in non-daemonic mode.
That
way the process won't terminate if there is still an active actor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink makeActorSystemsNonDaemonic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4259
----
commit 2d07bec48f6d7e83299df1414fa5873149877915
Author: Till Rohrmann <[email protected]>
Date: 2017-07-05T11:38:35Z
[FLINK-7105] Make ActorSystems non daemonic
In order to not having to explicitly wait on the termination of an
ActorSystem
in the main thread, we now create the ActorSystems in non-daemonic mode.
That
way the process won't terminate if there is still an active actor.
----
> Make ActorSystem creation per default non-daemonic
> --------------------------------------------------
>
> Key: FLINK-7105
> URL: https://issues.apache.org/jira/browse/FLINK-7105
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> At the moment, we create all {{ActorSystems}} with the setting
> {{daemonic=on}}. This has the consequence that we have to wait in the main
> thread on the {{ActorSystem's}} termination. By making the {{ActorSystems}}
> non-daemonic, we could get rid of this artifact. Especially since we have the
> {{ProcessReapers}} which terminate the process once a registered actor
> terminates.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
