[
https://issues.apache.org/jira/browse/FLINK-7018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076036#comment-16076036
]
ASF GitHub Bot commented on FLINK-7018:
---------------------------------------
GitHub user XuPingyong opened a pull request:
https://github.com/apache/flink/pull/4267
[FLINK-7018][streaming] Refactor streamGraph to make interfaces clear
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PingyongXu/flink FLINK-7018
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4267
----
commit 72660492a1cd51209b6186d40560abbca365359c
Author: pingyong.xpy <[email protected]>
Date: 2017-07-06T06:46:21Z
[FLINK-7018][streaming] Refactor streamGraph to make interfaces clear
----
> Refactor streamGraph to make interfaces clear
> ---------------------------------------------
>
> Key: FLINK-7018
> URL: https://issues.apache.org/jira/browse/FLINK-7018
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Xu Pingyong
> Assignee: Xu Pingyong
>
> Motivation:
> 1. StreamGraph is a graph consisted of some streamNodes. So virtual
> nodes (such as select, sideOutput, partition) should be moved away from it.
> Main iterfaces of StreamGraph should be as following：
> addSource(StreamNode sourceNode)
> addSink(StreamNode sinkNode)
> addOperator(StreamNode streamNode)
> addEdge(Integer upStreamVertexID, Integer downStreamVertexID,
> StreamEdge.InputOrder inputOrder, StreamPartitioner<?> partitioner,
> List<String> outputNames, OutputTag outputTag)
> getJobGraph()
> 2. StreamExecutionEnvironment should not be in StreamGraph, I create
> StreamGraphProperties which extracts all information the streamGraph needs
> from StreamExecutionEnvironment. It contains:
> 1) executionConfig
> 2) checkpointConfig
> 3) timeCharacteristic
> 4) stateBackend
> 5) chainingEnabled
> 6) cachedFiles
> 7) jobName
>
> Related Changes:
> I moved the part of dealing with virtual nodes to
> StreamGraphGenerator. And get properties of StreamGraph from
> StreamGraphProperties instead of StreamExecutionEnvironment.
>
> It is only a code abstraction internally.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
