Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r125910462
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -548,6 +565,7 @@ protected Object clone() throws
CloneNotSupportedException {
public ParameterTool mergeWith(ParameterTool other) {
ParameterTool ret = new ParameterTool(this.data);
ret.data.putAll(other.data);
+ ret.unrequestedParameters.addAll(other.data.keySet());
--- End diff --
The docs should probably state how unrequested parameters are handles here,
i.e. the returned `ParameterTool` will have have its unrequested parameters
reset. An alternative idiom may be to actually keep the old
`unrequestedParameters` in `ret` and merge them with
`other.unrequestedParameters`. What do you thinks makes most sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
