[ 
https://issues.apache.org/jira/browse/FLINK-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wyp updated FLINK-7122:
-----------------------
    Description: 
When metric name contains special characters then Graphite will not display 
them, because Graphite(GraphiteUDP) only replace white space to 
{{-}}(See:[GraphiteUDP.java|https://github.com/dropwizard/metrics/blob/3.1-maintenance/metrics-graphite/src/main/java/com/codahale/metrics/graphite/GraphiteUDP.java#L109]).
 But Flink metric variable's associated value like this:
{code}
<job_id> -> 9e81f84c50820c304b8af2b16fa8140b
<task_id> -> cbc357ccb763df2852fee8c4fc7d55f2
<task_attempt_id> -> 690a6cebdd1bfa9edacfed50aa1d4807
<host> -> localhost
<operator_name> -> Sink: es
<task_name> -> Source: Custom Source -> TestFlat -> Map -> Sink: es
<task_attempt_num> -> 0
<job_name> -> MyFlinkJobs
<tm_id> -> 34d31d54c0031328a6ec8910e571a7f8
<subtask_index> -> 0
{code}
then {{metrics.scope.task}} 's full name will be
{{flinkjobs.localhost.taskmanager.34d31d54c0031328a6ec8910e571a7f8.MyFlinkJobs.Source:
 Custom Source -> TestFlat -> Map -> Sink: es.0}}, but this will not be display 
in Graphite, because Graphite didn't support {{:}},{{>}} etc. special 
characters. we should replace them.

  was:
When metric name contains special characters then Graphite will not display 
them, because Graphite(GraphiteUDP) only replace white space to 
{{-}}(See:[GraphiteUDP.java|https://github.com/dropwizard/metrics/blob/3.1-maintenance/metrics-graphite/src/main/java/com/codahale/metrics/graphite/GraphiteUDP.java#L109]).
 But Flink metric variable's associated value like this:
{code}
<job_id> -> 9e81f84c50820c304b8af2b16fa8140b
<task_id> -> cbc357ccb763df2852fee8c4fc7d55f2
<task_attempt_id> -> 690a6cebdd1bfa9edacfed50aa1d4807
<host> -> localhost
<operator_name> -> Sink: es
<task_name> -> Source: Custom Source -> TestFlat -> Map -> Sink: es
<task_attempt_num> -> 0
<job_name> -> MyFlinkJobs
<tm_id> -> 34d31d54c0031328a6ec8910e571a7f8
<subtask_index> -> 0
{code}
then {{metrics.scope.task}} 's full name will be
{{flinkjobs.localhost.taskmanager.34d31d54c0031328a6ec8910e571a7f8.MyFlinkJobs.Source:
 Custom Source -> TestFlat -> Map -> Sink: es.0}}, but this will not be display 
in Graphite, because Graphite didn't support {{:}},{{>}} etc. special 
characters.


> When metric name contains special characters then Graphite will not display 
> them
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-7122
>                 URL: https://issues.apache.org/jira/browse/FLINK-7122
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.3.1
>            Reporter: wyp
>            Priority: Minor
>
> When metric name contains special characters then Graphite will not display 
> them, because Graphite(GraphiteUDP) only replace white space to 
> {{-}}(See:[GraphiteUDP.java|https://github.com/dropwizard/metrics/blob/3.1-maintenance/metrics-graphite/src/main/java/com/codahale/metrics/graphite/GraphiteUDP.java#L109]).
>  But Flink metric variable's associated value like this:
> {code}
> <job_id> -> 9e81f84c50820c304b8af2b16fa8140b
> <task_id> -> cbc357ccb763df2852fee8c4fc7d55f2
> <task_attempt_id> -> 690a6cebdd1bfa9edacfed50aa1d4807
> <host> -> localhost
> <operator_name> -> Sink: es
> <task_name> -> Source: Custom Source -> TestFlat -> Map -> Sink: es
> <task_attempt_num> -> 0
> <job_name> -> MyFlinkJobs
> <tm_id> -> 34d31d54c0031328a6ec8910e571a7f8
> <subtask_index> -> 0
> {code}
> then {{metrics.scope.task}} 's full name will be
> {{flinkjobs.localhost.taskmanager.34d31d54c0031328a6ec8910e571a7f8.MyFlinkJobs.Source:
>  Custom Source -> TestFlat -> Map -> Sink: es.0}}, but this will not be 
> display in Graphite, because Graphite didn't support {{:}},{{>}} etc. special 
> characters. we should replace them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to