[
https://issues.apache.org/jira/browse/FLINK-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080095#comment-16080095
]
ASF GitHub Bot commented on FLINK-7099:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4278#discussion_r126381441
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -185,8 +185,8 @@ public static WebMonitor startWebMonitorIfConfigured(
// this ensures correct values are present in the web frontend
final Address address = AkkaUtils.getAddress(actorSystem);
- config.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
address.host().get());
- config.setString(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY,
address.port().get().toString());
+ config.setString(JobManagerOptions.ADDRESS,
address.host().get());
+ config.setInteger(JobManagerOptions.PORT,
Integer.parseInt(address.port().get().toString()));
--- End diff --
I don't think we can cast it to Integer since it is a scala Int
actually...let's keep it as it is.
> Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY
> -----------------------------------------------------
>
> Key: FLINK-7099
> URL: https://issues.apache.org/jira/browse/FLINK-7099
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, Local Runtime
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> The deprecated {{ConfigConstants#JOB_MANAGER_IPC_PORT_KEY}} is still used a
> lot.
> We should replace these usages with {{JobManagerOptions#PORT}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
