[
https://issues.apache.org/jira/browse/FLINK-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080209#comment-16080209
]
ASF GitHub Bot commented on FLINK-7052:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4158#discussion_r126398901
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -551,33 +425,17 @@ else if (response == RETURN_ERROR) {
* @param jobID
* the ID of job the BLOB belongs to or <code>null</code> to
indicate the upload of a
* content-addressable BLOB
- * @param key
- * the key of the BLOB to upload or <code>null</code> to
indicate the upload of a content-addressable BLOB
* @throws IOException
* thrown if an I/O error occurs while writing the header data
to the output stream
*/
- private void sendPutHeader(OutputStream outputStream, JobID jobID,
String key) throws IOException {
- // sanity check that either both are null or both are not null
- if ((jobID != null || key != null) && !(jobID != null && key !=
null)) {
- throw new IllegalArgumentException();
- }
+ private void sendPutHeader(OutputStream outputStream, JobID jobID)
throws IOException {
+ checkArgument(jobID == null);
--- End diff --
no - in this PR, the jobID is not used anymore - a future PR will add uses
for that again
> remove NAME_ADDRESSABLE mode
> ----------------------------
>
> Key: FLINK-7052
> URL: https://issues.apache.org/jira/browse/FLINK-7052
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> Remove the BLOB store's {{NAME_ADDRESSABLE}} mode as it is currently not used
> and partly broken.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
