[
https://issues.apache.org/jira/browse/FLINK-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080292#comment-16080292
]
ASF GitHub Bot commented on FLINK-6357:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126412849
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -187,35 +252,122 @@ public void testUnrequestedShort() {
// test repeated access
Assert.assertEquals(2, parameter.getShort("short"));
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
+ }
+
+ @Test
+ public void testUnrequestedShortWithDefaultValue() {
+ ParameterTool parameter = ParameterTool.fromArgs(new
String[]{"-short", "2"});
+ Assert.assertEquals(Sets.newHashSet("short"),
parameter.getUnrequestedParameters());
+
+ // test parameter access
+ Assert.assertEquals(2, parameter.getShort("short", (short) 0));
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
+
+ // test repeated access
+ Assert.assertEquals(2, parameter.getShort("short", (short) 0));
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
}
@Test
+ public void testUnrequestedShortWithMissingValue() {
+ ParameterTool parameter = ParameterTool.fromArgs(new
String[]{"-short"});
+ Assert.assertEquals(Sets.newHashSet("short"),
parameter.getUnrequestedParameters());
+
+ exception.expect(RuntimeException.class);
+ exception.expectMessage("For input string: \"__NO_VALUE_KEY\"");
+
+ parameter.getShort("short");
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
+ }
+
+ // Int
+
+ @Test
public void testUnrequestedInt() {
ParameterTool parameter = ParameterTool.fromArgs(new
String[]{"-int", "4"});
Assert.assertEquals(Sets.newHashSet("int"),
parameter.getUnrequestedParameters());
// test parameter access
- Assert.assertEquals(4, parameter.getByte("int"));
+ Assert.assertEquals(4, parameter.getInt("int"));
--- End diff --
nice catch, didn't see this one before
> ParameterTool get unrequested parameters
> ----------------------------------------
>
> Key: FLINK-6357
> URL: https://issues.apache.org/jira/browse/FLINK-6357
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Affects Versions: 1.3.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Minor
>
> The Gelly examples use {{ParameterTool}} to parse required and optional
> parameters. In the latter case we should detect if a user mistypes a
> parameter name. I would like to add a {{Set<String>
> getUnrequestedParameters()}} method returning parameter names not requested
> by {{has}} or any of the {{get}} methods.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
