Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4279#discussion_r126617388
  
    --- Diff: docs/dev/table/tableApi.md ---
    @@ -373,7 +373,7 @@ Table result = orders
         <tr>
           <td>
             <strong>Distinct</strong><br>
    -        <span class="label label-primary">Batch</span>
    +        <span class="label label-primary">Batch</span> <span class="label 
label-primary">Streaming</span>
    --- End diff --
    
    If the input is append/insert only, distinct will only produce insert 
changes as well. 
    However, I don't think we make this distinction in the decoration phase. 
AFAIK, it will always be marked to produce updates right now.
    
    IMO, it would be good if DISTINCT on append-only input would not be treated 
as producing updates. We don't have to fix it in this PR, but I think it would 
be good to make such a change. What do you think @wuchong?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to