[
https://issues.apache.org/jira/browse/FLINK-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082186#comment-16082186
]
ASF GitHub Bot commented on FLINK-6617:
---------------------------------------
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3943
@wuchong @sunjincheng121 @fhueske
I tried to simplify the package structure a little bit. I based my changes
on top of this PRs commit.
My goals:
- splitting a class like (`ExpressionReductionTest`) in 6 classes is not
very helpful
- tests are named like the operator or feature that they are testing e.g.
`Calc`, `Distinct` etc. (we don't need `CastingITCase`, `CalcITCase`,
`ScalarFunctionITCase`; `CalcITCase` covers everything)
- all tests have the same name everywhere (`OverWindowTest`,
`OverWindowValidationTest`, `OverWindowITCase`,
`OverWindowStringExpressionTest`)
- no packages with one class
- `org.apache.flink.table.api` contains all tests that test the translation
from batch/stream/table/sql APIs
- `org.apache.flink.table.plan` contains all tests that modify the plan
- `org.apache.flink.table.runtime` contains all ITCases and runtime
relevant tests
- all other package contain unit tests for the classes of the same package
You can find my branch here:
https://github.com/apache/flink/compare/master...twalthr:FLINK-6617
> Improve JAVA and SCALA logical plans consistent test
> ----------------------------------------------------
>
> Key: FLINK-6617
> URL: https://issues.apache.org/jira/browse/FLINK-6617
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Currently,we need some `StringExpression` test,for all JAVA and SCALA API.
> Such as:`GroupAggregations`,`GroupWindowAggregaton`(Session,Tumble),`Calc`
> etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
