[ 
https://issues.apache.org/jira/browse/FLINK-6693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082533#comment-16082533
 ] 

ASF GitHub Bot commented on FLINK-6693:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4078#discussion_r126747879
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/DateFormatCallGen.scala
 ---
    @@ -0,0 +1,44 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.codegen.calls
    +
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo._
    +import org.apache.flink.table.codegen.{CodeGenerator, GeneratedExpression}
    +import 
org.apache.flink.table.codegen.calls.CallGenerator.generateCallIfArgsNotNull
    +
    +class DateFormatCallGen extends CallGenerator {
    +  override def generate(codeGenerator: CodeGenerator,
    +                        operands: Seq[GeneratedExpression])
    +  : GeneratedExpression = {
    +
    +    if (operands.last.literal) {
    +      val formatter = codeGenerator.addReusableDateFormatter(operands.last)
    +      generateCallIfArgsNotNull(codeGenerator.nullCheck, STRING_TYPE_INFO, 
operands) {
    +        terms =>s"$formatter.print(${terms.head})"
    --- End diff --
    
    +space between `=>` and `s`


> Support DATE_FORMAT function in the Table / SQL API
> ---------------------------------------------------
>
>                 Key: FLINK-6693
>                 URL: https://issues.apache.org/jira/browse/FLINK-6693
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>
> It would be quite handy to support the {{DATE_FORMAT}} function in Flink to 
> support various date / time related operations:
> The specification of the {{DATE_FORMAT}} function can be found in 
> https://prestodb.io/docs/current/functions/datetime.html.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to