Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4105#discussion_r126883954
  
    --- Diff: 
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/utils/UserDefinedAggFunctions.java
 ---
    @@ -59,7 +59,7 @@ public boolean requiresOver() {
        /**
         * Accumulator for WeightedAvg.
         */
    -   public static class WeightedAvgAccum extends Tuple2<Long, Integer> {
    --- End diff --
    
    Yes, you are right. Either we change the type or we touch the code and use 
`acc.f0` instead of `acc.sum` and `acc.f1` instead of `acc.count`.
    
    Let's go with your approach.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to