[
https://issues.apache.org/jira/browse/FLINK-7163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083710#comment-16083710
]
ASF GitHub Bot commented on FLINK-7163:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4308#discussion_r126907470
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -687,11 +687,11 @@ case class LogicalTableFunctionCall(
parameters: Seq[Expression],
resultType: TypeInformation[_],
fieldNames: Array[String],
- child: LogicalNode)
+ child: LogicalNode,
+ evalMethod: Option[Method])
--- End diff --
You can make the evalMethod default as None, so you do not need to change
every call.
> Make LogicalTableFunctionCall immutable
> ---------------------------------------
>
> Key: FLINK-7163
> URL: https://issues.apache.org/jira/browse/FLINK-7163
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Ruidong Li
> Assignee: Ruidong Li
>
> All sub-classes of LogicalNode are immutable except for
> `LogicalTableFunctionCall`, it's better to make LogicalTableFunctionCall
> immutable
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
