[ 
https://issues.apache.org/jira/browse/FLINK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084176#comment-16084176
 ] 

ASF GitHub Bot commented on FLINK-7047:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4233#discussion_r126991245
  
    --- Diff: pom.xml ---
    @@ -858,32 +856,6 @@ under the License.
                                </plugins>
                        </build>
                </profile>
    -           <!--
    -                   Test profile A excludes all tests starting with (A-M).
    -                   profile B excludes tests (N-Z).
    -                   This allows us to split up the test execution into 
separate profiles.
    -           -->
    -           <profile>
    -                   <id>flink-fast-tests-a</id>
    -                   <properties>
    -                           <!-- Allow A-I by forbidding J-Z -->
    -                           
<flink-fast-tests-pattern>%regex[.*/[J-Z].*]</flink-fast-tests-pattern>
    -                   </properties>
    -           </profile>
    -           <profile>
    -                   <id>flink-fast-tests-b</id>
    -                   <properties>
    -                           <!-- Allow J-R, forbid A-I and S - Z -->
    -                           
<flink-fast-tests-pattern>%regex[.*/[A-IS-Z].*]</flink-fast-tests-pattern>
    -                   </properties>
    -           </profile>
    -           <profile>
    -                   <id>flink-fast-tests-c</id>
    -                   <properties>
    -                           <!-- Allow S-Z, forbid A-R -->
    -                           
<flink-fast-tests-pattern>%regex[.*/[A-R].*]</flink-fast-tests-pattern>
    -                   </properties>
    -           </profile>
    --- End diff --
    
    I'm super happy to see this being removed :)


> Reorganize build profiles
> -------------------------
>
>                 Key: FLINK-7047
>                 URL: https://issues.apache.org/jira/browse/FLINK-7047
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests, Travis
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> With the current build times once again hitting the timeout it is time to 
> revisit our approach.
> The current approach of splitting all tests by name, while easy to maintain 
> or extend, has the big disadvantage that it's fairly binary in regards to the 
> timeout: either we're below the timeout and all builds pass, or we're above 
> and the entire merging process stalls. Furthermore, it requires all modules 
> to be compiled.
> I propose a different approach by which we bundle several modules, only 
> execute the tests of these modules and skip the compilation of some modules 
> that are not required for these tests.
> 5 groups are my current suggestion, which will result in 10 build profiles 
> total.
> The groups are:
> # *core* - core flink modules like core,runtime,streaming-java,metrics,rocksdb
> # *libraries* - flink-libraries and flink-storm
> # *connectors* - flink-connectors, flink-connector-wikiedits, 
> flink-tweet-inputformat
> # *tests* - flink-tests
> # *misc* - flink-yarn, fink-yarn-tests, flink-mesos, flink-examples, 
> flink-dist
> To not increase the total number of profiles to ridiculous numbers i also 
> propose to only test against 2 combinations of jdk+hadoop+scala:
> # oraclejdk8 + hadoop 2.8.0 + scala 2.11
> # openjdk7 + hadoop 2.4.1 + scala 2.10
> My current estimate is that this will cause profiles to take at most 40 
> minutes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to