[ 
https://issues.apache.org/jira/browse/FLINK-7137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085179#comment-16085179
 ] 

ASF GitHub Bot commented on FLINK-7137:
---------------------------------------

GitHub user walterddr opened a pull request:

    https://github.com/apache/flink/pull/4314

    [FLINK-7137] [table] Flink TableAPI supports nested CompositeType mapped to 
nullable calcite RelDataType by default

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/walterddr/flink FLINK-7137

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4314
    
----
commit 93c475b7da114a3022eb2b6fb8b46ffe8a1a6997
Author: Rong Rong <[email protected]>
Date:   2017-07-13T04:29:16Z

    Fixing nested fields not mapped to nullable calcite RelDataType by default

----


> Flink table API defaults top level fields as nullable and all nested fields 
> within CompositeType as non-nullable
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-7137
>                 URL: https://issues.apache.org/jira/browse/FLINK-7137
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.3.1
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>
> Right now FlinkTypeFactory does conversion between Flink TypeInformation to 
> Calcite RelDataType by assuming the following: 
> All top level fields will be set to nullable and all nested fields within 
> CompositeRelDataType and GenericRelDataType will be set to Calcite default 
> (which is non-nullable). 
> This triggers Calcite SQL optimization engine drop all `IS NOT NULL` clause 
> on nested fields, and would not be able to optimize when top level fields 
> were actually non-nullable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to