[
https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085242#comment-16085242
]
ASF GitHub Bot commented on FLINK-6951:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4150#discussion_r127135589
--- Diff: flink-connectors/flink-connector-kinesis/pom.xml ---
@@ -56,6 +58,18 @@ under the License.
</dependency>
<dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ <version>${apache.httpclient.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ <version>${apache.httpcore.version}</version>
+ </dependency>
--- End diff --
As Stephan mentioned, these shouldn't be needed to be declared. They'll
already be pulled in due to the `promoteTransitiveDependencies` property in the
shade config.
Adding them for the sake of hadoop-aws dependency doesn't make sense, for
the same reason as before; we shouldn't assume that the Kinesis connector user
will also use AWS S3.
> Incompatible versions of httpcomponents jars for Flink kinesis connector
> ------------------------------------------------------------------------
>
> Key: FLINK-6951
> URL: https://issues.apache.org/jira/browse/FLINK-6951
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
> Affects Versions: 1.3.0
> Reporter: Ted Yu
> Assignee: Bowen Li
>
> In the following thread, Bowen reported incompatible versions of
> httpcomponents jars for Flink kinesis connector :
> http://search-hadoop.com/m/Flink/VkLeQN2m5EySpb1?subj=Re+Incompatible+Apache+Http+lib+in+Flink+kinesis+connector
> We should find a solution such that users don't have to change dependency
> version(s) themselves when building Flink kinesis connector.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
