Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4150#discussion_r127138994
--- Diff: flink-connectors/flink-connector-kinesis/pom.xml ---
@@ -56,6 +58,18 @@ under the License.
</dependency>
<dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ <version>${apache.httpclient.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ <version>${apache.httpcore.version}</version>
+ </dependency>
--- End diff --
For `promoteTransitiveDependencies`, what does it really mean?
https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#promoteTransitiveDependencies
is kind of very confusing to understand.
To your second point, my intention is neither adding http-components 4.3.x
for hadoop-aws, nor for AWS s3. It is actually for aws-java-sdk-kinesis used by
flink-connector-kinesis. This way, users won't worry about versions of
http-components depended by aws-java-sdk-kinesis anymore. Does it make sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
