[
https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086659#comment-16086659
]
ASF GitHub Bot commented on FLINK-6493:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4328
[FLINK-6493] Fix ineffective null check in RegisteredOperatorBackendS…
This PR is simlar to https://github.com/apache/flink/pull/1871/files.
@tedyu What do you think of this Change ?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink
flink-6493-Ineffective-null-check-in-RegisteredOperatorBackendStateMetaInfo#equals
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4328
----
commit 5e771d6a877867cf450fd7ce40c069db6ce97482
Author: zhangminglei <[email protected]>
Date: 2017-07-14T00:48:51Z
[FLINK-6493] Fix ineffective null check in
RegisteredOperatorBackendStateMetaInfo#equals
----
> Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
> -------------------------------------------------------------------------
>
> Key: FLINK-6493
> URL: https://issues.apache.org/jira/browse/FLINK-6493
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> && ((partitionStateSerializer == null && ((Snapshot)
> obj).getPartitionStateSerializer() == null)
> || partitionStateSerializer.equals(((Snapshot)
> obj).getPartitionStateSerializer()))
> && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot)
> obj).getPartitionStateSerializerConfigSnapshot() == null)
> || partitionStateSerializerConfigSnapshot.equals(((Snapshot)
> obj).getPartitionStateSerializerConfigSnapshot()));
> {code}
> The null check for partitionStateSerializer /
> partitionStateSerializerConfigSnapshot is in combination with another clause.
> This may lead to NPE in the partitionStateSerializer.equals() call.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
