Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4187#discussion_r127400527
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -896,6 +896,28 @@ Thus, in order to infer the metric identifier:
       </tbody>
     </table>
     
    +#### Connector:
    +<table class="table table-bordered">
    +  <thead>
    +    <tr>
    +      <th class="text-left" style="width: 20%">Scope</th>
    +      <th class="text-left" style="width: 30%">Metrics</th>
    +      <th class="text-left" style="width: 50%">Description</th>
    +    </tr>
    +  </thead>
    +  <tbody>
    +    <tr>
    +      <th rowspan="1">Slot/Consumer</th>
    --- End diff --
    
    This documentation is inconsistent with the rest.
    
    Scope should be "Operator", and you should add an additional "Infix" column 
which contains the names of the metric groups you are creating, concatenated 
with a period.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to