Github user wuchong commented on the issue:

    https://github.com/apache/flink/pull/4324
  
    The code looks good to me. Good refactoring!
    
    +1 to merge.
    
    BTW, I have a question. This time-windowed join is different with 
`DataStream.join(...).window(...)`.  The `DataStream.join.window` is joining 
two streams on a same window (such as 1 hour tumbling window).  Do we have plan 
to support it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to