[ 
https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087631#comment-16087631
 ] 

ASF GitHub Bot commented on FLINK-7185:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4340#discussion_r127505648
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/io/TextOutputFormat.java ---
    @@ -18,65 +18,73 @@
     
     package org.apache.flink.api.java.io;
     
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.common.io.FileOutputFormat;
    +import org.apache.flink.core.fs.Path;
    +
     import java.io.IOException;
     import java.io.Serializable;
     import java.nio.charset.Charset;
     import java.nio.charset.IllegalCharsetNameException;
     import java.nio.charset.UnsupportedCharsetException;
     
    -import org.apache.flink.annotation.PublicEvolving;
    -import org.apache.flink.api.common.io.FileOutputFormat;
    -import org.apache.flink.core.fs.Path;
    -
    +/**
    + * {@link FileOutputFormat} that stores values by calling {@link 
Object#toString()} method.
    --- End diff --
    
    This isn't necessarily correct, as a `TextFormatter` might be used.
    
    How about
    ```
    A {@link FileOutputFormat} that writes objects to a text file.
    
    <p>Objects are converted to Strings using either {@link Object#toString()} 
or a {@link TextFormatter}.
    ```


> Activate checkstyle flink-java/io
> ---------------------------------
>
>                 Key: FLINK-7185
>                 URL: https://issues.apache.org/jira/browse/FLINK-7185
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to