[
https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089356#comment-16089356
]
ASF GitHub Bot commented on FLINK-6998:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127636481
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -293,12 +296,28 @@ public void shutdown() {
* @param offsetsToCommit The offsets to commit
*/
public void setOffsetsToCommit(Map<TopicPartition, OffsetAndMetadata>
offsetsToCommit) {
+ setOffsetsToCommit(offsetsToCommit, null);
+ }
+
+ /**
+ * Tells this thread to commit a set of offsets. This method does not
block, the committing
+ * operation will happen asynchronously.
+ *
+ * <p>Only one commit operation may be pending at any time. If the
committing takes longer than
+ * the frequency with which this method is called, then some commits
may be skipped due to being
+ * superseded by newer ones.
--- End diff --
Unnecessary empty space.
> Kafka connector needs to expose metrics for failed/successful offset commits
> in the Kafka Consumer callback
> -----------------------------------------------------------------------------------------------------------
>
> Key: FLINK-6998
> URL: https://issues.apache.org/jira/browse/FLINK-6998
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Reporter: Zhenzhong Xu
> Assignee: Zhenzhong Xu
>
> Propose to add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in
> KafkaConsumerThread class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
