Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/3672#discussion_r127641085
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointStateRestoreTest.java
---
@@ -66,10 +66,19 @@
public void testSetState() {
try {
- final ChainedStateHandle<StreamStateHandle>
serializedState = CheckpointCoordinatorTest.generateChainedStateHandle(new
SerializableObject());
- KeyGroupRange keyGroupRange = KeyGroupRange.of(0,0);
- List<SerializableObject> testStates =
Collections.singletonList(new SerializableObject());
- final KeyedStateHandle serializedKeyGroupStates =
CheckpointCoordinatorTest.generateKeyGroupState(keyGroupRange, testStates);
+ final ChainedStateHandle<StreamStateHandle>
serializedState1 = CheckpointCoordinatorTest.generateChainedStateHandle(new
SerializableObject());
--- End diff --
Could you write in commit message what are actually fixing? And could you
also add some commit title that sums up your changes?
After this commit, will this test start failing and only next commits fix
that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---