[ 
https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089495#comment-16089495
 ] 

ASF GitHub Bot commented on FLINK-6887:
---------------------------------------

Github user wuchong commented on the issue:

    https://github.com/apache/flink/pull/4171
  
    @fhueske  thanks for reviewing. I had fixed the code style issue. 
    
    I will merge this once the CI pass.


> Split up CodeGenerator into several specific CodeGenerator
> ----------------------------------------------------------
>
>                 Key: FLINK-6887
>                 URL: https://issues.apache.org/jira/browse/FLINK-6887
>             Project: Flink
>          Issue Type: Task
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>             Fix For: 1.4.0
>
>
> Currently, the {{CodeGenerator}} is very huge and a bit difficult to 
> maintain. I suggest to split it up into several specific {{XXXCodeGenerator}}.
> For example, create {{AggregationFunctionCodeGenerator}}  class and make it 
> extend to {{CodeGenerator}} and move the {{def generateAggregations(...)}} 
> method to it. The same as {{TableFunctionCollectorCodeGenerator}} and 
> {{InputFormatCodeGenerator}}.
> What do you think? [~fhueske], [~twalthr], [~sunjincheng121]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to