Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4348#discussion_r127715580
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -131,7 +131,8 @@ class GroupAggProcessFunction(
// if this was not the first row and we have to emit retractions
if (generateRetraction && !firstRow) {
- if (prevRow.row.equals(newRow.row)) {
+ // the condition of !stateCleaningEnabled is avoided state to be
cleaned up too early
--- End diff --
Make sense to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
