[ 
https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090335#comment-16090335
 ] 

ASF GitHub Bot commented on FLINK-7162:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4311#discussion_r127793662
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerStartupTest.java
 ---
    @@ -51,11 +54,14 @@
     
        private File blobStorageDirectory;
     
    +   @Rule
    +   public TemporaryFolder temporaryFolder = new TemporaryFolder();
    --- End diff --
    
    Same here...


> Tests should not write outside 'target' directory.
> --------------------------------------------------
>
>                 Key: FLINK-7162
>                 URL: https://issues.apache.org/jira/browse/FLINK-7162
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: mingleizhang
>            Assignee: mingleizhang
>
> A few tests use Files.createTempDir() from Guava package, but do not set 
> java.io.tmpdir system property. Thus the temp directory is created in 
> unpredictable places and is not being cleaned up by {{mvn clean}}.
> This was probably introduced in {{JobManagerStartupTest}} and then replicated 
> in {{BlobUtilsTest}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to