[
https://issues.apache.org/jira/browse/FLINK-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090415#comment-16090415
]
ASF GitHub Bot commented on FLINK-7067:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4254
I think this is a meaningful fix.
I would suggest to do the tests different, though. The tests of the
CheckpointCoordinator overdo the mockito stuff so heavily that it becomes an
extremely hard job to change anything in the CheckpointCoordinator. Mocks are
super maintenance heavy, compared to actual test implementations of interfaces
or classes.
> Cancel with savepoint does not restart checkpoint scheduler on failure
> ----------------------------------------------------------------------
>
> Key: FLINK-7067
> URL: https://issues.apache.org/jira/browse/FLINK-7067
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.3.1
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
> Priority: Blocker
> Fix For: 1.3.2
>
>
> The `CancelWithSavepoint` action of the JobManager first stops the checkpoint
> scheduler, then triggers a savepoint, and cancels the job after the savepoint
> completes.
> If the savepoint fails, the command should not have any side effects and we
> don't cancel the job. The issue is that the checkpoint scheduler is not
> restarted though.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
