[ 
https://issues.apache.org/jira/browse/FLINK-6893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090992#comment-16090992
 ] 

ASF GitHub Bot commented on FLINK-6893:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4128#discussion_r127868565
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
 ---
    @@ -352,6 +352,14 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
           "Flink~~~~xx")
       }
     
    +  @Test
    +  def testBin(): Unit = {
    +    testSqlApi("BIN(12)", "1100")
    +    testSqlApi("BIN(10)", "1010")
    +    testSqlApi("BIN(0)", "0")
    +    
testSqlApi("BIN(f32)","1111111111111111111111111111111111111111111111111111111111111111")
    +  }
    +
    --- End diff --
    
    Would be better to add validation tests to `ScalarFunctionsValidationTest` 
to check the expected exception for unsupported operand types.


> Add BIN supported in SQL
> ------------------------
>
>                 Key: FLINK-6893
>                 URL: https://issues.apache.org/jira/browse/FLINK-6893
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> BIN(N) Returns a string representation of the binary value of N, where N is a 
> longlong (BIGINT) number. This is equivalent to CONV(N,10,2). Returns NULL if 
> N is NULL.
> * Syntax:
> BIN(num)
> * Arguments
> **num: a long/bigint value
> * Return Types
>   String
> * Example:
>   BIN(12) -> '1100'
> * See more:
> ** [MySQL| 
> https://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_bin]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to