[
https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091324#comment-16091324
]
ASF GitHub Bot commented on FLINK-7058:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4240
@aljoscha Yeah, so this doesn't affect 1.3. In 1.3 scala 2.10 is still the
default, so it needs the reverse logic of this PR, which, well, is the one that
was present in 1.3.
> flink-scala-shell unintended dependencies for scala 2.11
> --------------------------------------------------------
>
> Key: FLINK-7058
> URL: https://issues.apache.org/jira/browse/FLINK-7058
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.3.0, 1.3.1
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Critical
> Fix For: 1.4.0, 1.3.2
>
>
> Activation of profile scala-2.10 in `flink-scala-shell` and `flink-scala` do
> not work as intended.
> {code:xml}
> <profiles>
> <profile>
> <id>scala-2.10</id>
> <activation>
> <property>
> <name>!scala-2.11</name>
> </property>
> </activation>
> <dependencies>
> <dependency>
> <groupId>org.scalamacros</groupId>
>
> <artifactId>quasiquotes_2.10</artifactId>
>
> <version>${scala.macros.version}</version>
> </dependency>
> <dependency>
> <groupId>org.scala-lang</groupId>
> <artifactId>jline</artifactId>
> <version>2.10.4</version>
> </dependency>
> </dependencies>
> </profile>
> </profiles>
> <activation>
> </activation>
> {code}
> This activation IMO have nothing to do with `-Pscala-2.11` profile switch
> used in our build. "properties" are defined by `-Dproperty` switches. As far
> as I understand that, those additional dependencies would be added only if
> nobody defined property named `scala-2.11`, which means, they would be added
> only if switch `-Dscala-2.11` was not used, so it seems like those
> dependencies were basically added always. This quick test proves that I'm
> correct:
> {code:bash}
> $ mvn dependency:tree -pl flink-scala | grep quasi
> [INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
> $ mvn dependency:tree -pl flink-scala -Pscala-2.11 | grep quasi
> [INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
> $ mvn dependency:tree -pl flink-scala -Pscala-2.10 | grep quasi
> [INFO] +- org.scalamacros:quasiquotes_2.10:jar:2.1.0:compile
> {code}
> regardless of the selected profile those dependencies are always there.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
