[ 
https://issues.apache.org/jira/browse/FLINK-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091780#comment-16091780
 ] 

ASF GitHub Bot commented on FLINK-7102:
---------------------------------------

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/4255
  
    you're right - wasn't looking thoroughly enough (and only recently learned 
about `ExpectedException`).
    
    Additionally, I found out that this ignored exception was actually required 
to be thrown for some of these tests while others didn't even throw it. So with 
the newest changes (also rebased on top of the current `master`), the tests 
actually better reflect the intended behaviour.


> improve ClassLoaderITCase
> -------------------------
>
>                 Key: FLINK-7102
>                 URL: https://issues.apache.org/jira/browse/FLINK-7102
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> {{ClassLoaderITCase}}...
> * unnecessarily runs multiple tests in a single test case
> * {{#testDisposeSavepointWithCustomKvState()}} does not cancel its job (thus 
> the order of execution of test cases defines the outcome)
> * uses {{e.getCause().getCause()}} which may cause {{NullPointerException}}s 
> hiding the original error



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to