Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4239
  
    `df6d5e0` to `5ff8106` should definitely be squashed, I left them only to 
make it easier for reviewers to follow the changes made in 0.11 vs 0.10 
connectors (those changes would be invisible in one blob commit).
    
    For `321a142` to `2cf5f3b` I'm not sure about the first one, 
`FlinkKafkaProducer` is that hacky that it could deserve separate commit. It 
would make it stand out more if anyone in the future would look at the commit 
history/changes (it could hide in larger change).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to