Github user uce commented on the pull request:
https://github.com/apache/flink/pull/729#issuecomment-109259623
Thanks for the changes. :-) They look very good. Cluster tests are also
fine.
---
I would like to address the following points, squash your commits and merge
it. Is this fine with you?
1. Add the function name to the CodeErrorExceptions. Currently you just get
```
Exception in thread "main"
org.apache.flink.api.java.sca.CodeErrorException: Function code contains
obvious errors. If you think the code analysis is wrong at this point you can
disable the entire code analyzer in ExecutionConfig or add @SkipCodeAnalysis to
your function to disable the analysis.
at
org.apache.flink.api.java.sca.UdfAnalyzer.analyze(UdfAnalyzer.java:328)
at
org.apache.flink.api.java.operators.UdfOperatorUtils.analyzeSingleInputUdf(UdfOperatorUtils.java:46)
at
org.apache.flink.api.java.operators.FilterOperator.<init>(FilterOperator.java:45)
at org.apache.flink.api.java.DataSet.filter(DataSet.java:282)
at Job.main(Job.java:43)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
Caused by: org.apache.flink.api.java.sca.CodeErrorException: Function
contains tuple accesses with invalid indexes. This can lead to errors during
runtime.
```
but it is important to see, which function exactly failed.
2. We now print the hint string in `OPTIMIZE` mode, but I think we should
make it even more explicit when an optimization is applied.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
