Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4312
  
    I think this is a good case where the new pull request template would have 
been useful.
    This is in fact a change with potential performance impact.
    
    Part of the result of the last micro-benchmarks by Piotr was that we 
already introduced overhead and performance regressions along the collectors 
and contexts. Additional branch and method indirection did 
    eventually add up to make the code less efficient and less JIT friendly.
    
    I am very worried that these types of changes continue to be made without 
any consideration of potential impact.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to