Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4149
  
    @zhenzhongxu at the very least, I would expose these new values as 
protected methods, and let the fields be private. Then, have particular tests 
that verify the values are correct.
    
    The exposing methods should have good Javadoc on the purpose of exposing 
them (and in what cases they could be used for).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to