[ 
https://issues.apache.org/jira/browse/FLINK-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094228#comment-16094228
 ] 

ASF GitHub Bot commented on FLINK-6923:
---------------------------------------

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4149
  
    @zhenzhongxu at the very least, I would expose these new values as 
protected methods, and let the fields be private. Then, have particular tests 
that verify the values are correct.
    
    The exposing methods should have good Javadoc on the purpose of exposing 
them (and in what cases they could be used for).


> Kafka connector needs to expose information about in-flight record in 
> AbstractFetcher base class
> ------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6923
>                 URL: https://issues.apache.org/jira/browse/FLINK-6923
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Zhenzhong Xu
>            Assignee: Zhenzhong Xu
>            Priority: Minor
>
> We have a use case where we have our custom Fetcher implementation that 
> extends AbstractFetcher base class. We need to periodically get current in 
> flight (in processing) records' partition and offset information. 
> This can be easily exposed in AbstractFetcher class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to