[
https://issues.apache.org/jira/browse/FLINK-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094444#comment-16094444
]
ASF GitHub Bot commented on FLINK-7233:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4378
[FLINK-7233][tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest
This fixes `getRandomConfig()` being prone to integer overflows and creating
invalid configuration values.
- [X] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [X] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7233
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4378
----
commit d0a5e3116b4aefc10603a43d077583e2f7cd99de
Author: Nico Kruber <[email protected]>
Date: 2017-07-20T09:44:08Z
[FLINK-7233][tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest
This fixes getRandomConfig() being prone to integer overflows and creating
invalid configuration values.
----
> TaskManagerHeapSizeCalculationJavaBashTest failed on Travis
> -----------------------------------------------------------
>
> Key: FLINK-7233
> URL: https://issues.apache.org/jira/browse/FLINK-7233
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.3.0, 1.3.1, 1.4.0, 1.3.2
> Environment: https://travis-ci.org/apache/flink/jobs/255289918
> https://travis-ci.org/apache/flink/jobs/255289934
> Reporter: Chesnay Schepler
> Labels: test-stability
>
> {code}
> Running org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.926 sec <<<
> FAILURE! - in org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest
> compareNetworkBufShellScriptWithJava(org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest)
> Time elapsed: 1.443 sec <<< ERROR!
> org.apache.flink.configuration.IllegalConfigurationException: Invalid
> configuration value for taskmanager.network.memory.min : -2147479274 -
> Minimum memory for network buffers must allow at least one network buffer
> with respect to the memory segment size
> at
> org.apache.flink.runtime.taskexecutor.TaskManagerServicesConfiguration.checkConfigParameter(TaskManagerServicesConfiguration.java:459)
> at
> org.apache.flink.runtime.taskexecutor.TaskManagerServicesConfiguration.checkNetworkBufferConfig(TaskManagerServicesConfiguration.java:397)
> at
> org.apache.flink.runtime.taskexecutor.TaskManagerServices.calculateNetworkBufferMemory(TaskManagerServices.java:427)
> at
> org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest.getRandomConfig(TaskManagerHeapSizeCalculationJavaBashTest.java:198)
> at
> org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest.compareNetworkBufShellScriptWithJava(TaskManagerHeapSizeCalculationJavaBashTest.java:95)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
