[
https://issues.apache.org/jira/browse/FLINK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094485#comment-16094485
]
ASF GitHub Bot commented on FLINK-7176:
---------------------------------------
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4330
+1
I wouldn't say, `return`is uncommon inside a bash function!
`exit` in these methods would immediately exit the bash script while
`return` does what is expected here which still allows the `transfer.sh` uploads
> Failed builds (due to compilation) don't upload logs
> ----------------------------------------------------
>
> Key: FLINK-7176
> URL: https://issues.apache.org/jira/browse/FLINK-7176
> Project: Flink
> Issue Type: Bug
> Components: Travis
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.3.0, 1.4.0
>
>
> If the compile phase fails on travis {{flink-dist}} may not be created. This
> causes the check for the inclusion of snappy in {{flink-dist}} to fail.
> The function doing this check calls {{exit 1}} on error, which exits the
> entire shell, thus skipping subsequent actions like the upload of logs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
