[ 
https://issues.apache.org/jira/browse/FLINK-7234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097466#comment-16097466
 ] 

ASF GitHub Bot commented on FLINK-7234:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4372
  
    @fhueske I started running some benchmarks on HITS with each of the 
combiners (sort, hash, none) and at small scales hash is fasted followed by 
none with sort in last. None is somewhat faster than hash for very small 
graphs. I've gotten stuck on scale 23 where the job is deadlocking on the first 
iteration for all three types. Interestingly I also see the deadlock on my 
laptop running from IntelliJ. I need to look more because I'm not seeing what 
is releasing memory buffers when all operators are seemingly waiting on 
acquiring a buffer from `LocalBufferPool`.


> Fix CombineHint documentation
> -----------------------------
>
>                 Key: FLINK-7234
>                 URL: https://issues.apache.org/jira/browse/FLINK-7234
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.2.2, 1.4.0, 1.3.2
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> The {{CombineHint}} 
> [documentation|https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/batch/index.html]
>  applies to {{DataSet#reduce}} not {{DataSet#reduceGroup}} and should also be 
> note for {{DataSet#distinct}}. It is also set with 
> {{.setCombineHint(CombineHint)}} rather than alongside the UDF parameter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to