GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4392

    [FLINK-7226] [webUI] Properly include UTF-8 in content-type header

    This PR corrects the `content-encoding` header introduced in FLINK-5705. As 
documented 
[here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding)
 this header is used to denote how the content is compressed (for example, with 
gzip or deflate).
    
    That the strings are encoded using `UTF-8` should be documented in the 
`content-type` header instead, using the `charset` parameter, as documented 
[here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type).
    
    There was also a bug in `TestBaseUtils#getFromHTTP`, where the UTF-8 
charset was retrieved from the `content-encoding` header.
    
    I've added tests to make sure we don't break this _again_.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7226

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4392
    
----
commit 3093d53f6f07afcc351b99a39586463fb0a0b83e
Author: zentol <[email protected]>
Date:   2017-07-19T11:51:35Z

    [FLINK-7226] [webUI] Properly include UTF-8 in content-type header

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to