[
https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099876#comment-16099876
]
ASF GitHub Bot commented on FLINK-7213:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4353#discussion_r129274874
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointStateRestoreTest.java
---
@@ -118,10 +118,22 @@ public void testSetState() {
PendingCheckpoint pending =
coord.getPendingCheckpoints().values().iterator().next();
final long checkpointId = pending.getCheckpointId();
- SubtaskState checkpointStateHandles = new
SubtaskState(serializedState, null, null, serializedKeyGroupStates, null);
- coord.receiveAcknowledgeMessage(new
AcknowledgeCheckpoint(jid, statefulExec1.getAttemptId(), checkpointId, new
CheckpointMetrics(), checkpointStateHandles));
- coord.receiveAcknowledgeMessage(new
AcknowledgeCheckpoint(jid, statefulExec2.getAttemptId(), checkpointId, new
CheckpointMetrics(), checkpointStateHandles));
- coord.receiveAcknowledgeMessage(new
AcknowledgeCheckpoint(jid, statefulExec3.getAttemptId(), checkpointId, new
CheckpointMetrics(), checkpointStateHandles));
+ final TaskStateSnapshot subtaskStates = new
TaskStateSnapshot();
+
+ subtaskStates.putSubtaskStateByOperatorID(
+ OperatorID.fromJobVertexID(statefulId),
+ new OperatorSubtaskState(
+ serializedState.get(0),
+
Collections.<OperatorStateHandle>emptyList(),
+
Collections.<OperatorStateHandle>emptyList(),
+
Collections.singletonList(serializedKeyGroupStates),
+
Collections.<KeyedStateHandle>emptyList()));
+
+ //SubtaskState checkpointStateHandles = new
SubtaskState(serializedState, null, null, serializedKeyGroupStates, null);
--- End diff --
whats up with this line?
> Introduce state management by OperatorID in TaskManager
> -------------------------------------------------------
>
> Key: FLINK-7213
> URL: https://issues.apache.org/jira/browse/FLINK-7213
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.4.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> Flink-5892 introduced the job manager / checkpoint coordinator part of
> managing state on the operator level instead of the task level by introducing
> explicit operator_id -> state mappings. However, this explicit mapping was
> not introduced in the task manager side, so the explicit mapping is still
> converted into a mapping that suits the implicit operator chain order.
> We should also introduce explicit operator ids to state management on the
> task manager.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
